Share offline validation between job validate and job submit commands#8068
Conversation
saanikaguptamicrosoft
requested review from
JeffreyCA,
achauhan-scc,
hemarina,
kingernupur,
rabollin,
rajeshkamal5050,
tg-msft,
trangevi,
vhvb1989,
wbreza and
weikanglim
as code owners
jongio
left a comment
jongio
left a comment
There was a problem hiding this comment.
Clean refactoring - the shared validation path is straightforward and the new checks (reserved "default" output name, services validation) are well-tested.
One thing to clean up: job_submit.go still has two comments referencing the now-removed ValidateJobDefinition:
- Line ~164: // Services (e.g., SSH). Validation in ValidateJobDefinition restricts type to "ssh"
- Line ~173: // Currently only SSH is supported (enforced by ValidateJobDefinition).
These should say ValidateJobOffline instead.
Also, the PR description (Notes/Testing sections) is empty - might be worth filling in for reviewer context.
saanikaguptamicrosoft
merged commit cefaacb
into
Azure:foundry-training-dev
jongio
left a comment
jongio
left a comment
There was a problem hiding this comment.
Addresses my earlier comment - stale references updated. The new input/output type-required validations look correct: path-style inputs (no value:) must declare a type, and all outputs must too. Test coverage is solid (positive + negative cases for both). Nothing else to flag.
3 participants
Notes
Testing
Happy Path
Unhappy paths
